Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove deprecated methods and fields and rename enrollStatus field. #463

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: Remove deprecated methods and fields and rename enrollStatus field. #463

merged 2 commits into from
Nov 28, 2023

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented Nov 27, 2023 •
edited
Loading

- What I did

  • Since the at_commons version is updated to v4.0.0., removed the deprecated methods
  • Renamed 'EnrollStatus" as "EnrollmentStatus".
  • Removed "EnrollResponse" which currently does not have usage. Instead "AtEnrollmentResponse" is used which is defined in at_auth package.
  • Run code formatter

@gkc
Copy link
Contributor

gkc commented Nov 27, 2023

@sitaram-kalluri Checks are failing in at_commons

gkc
gkc requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failing in at_commons

@sitaram-kalluri sitaram-kalluri requested a review from gkc November 28, 2023 02:51
gkc
gkc approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sitaram-kalluri sitaram-kalluri merged commit 97e69b8 into trunk Nov 28, 2023
11 checks passed
@sitaram-kalluri sitaram-kalluri deleted the srk_commons_changes branch November 28, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris Awaiting requested review from murali-shris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitaram-kalluri @gkc