Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update exception handling for AtLookup.findSecondary() #469

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Dec 4, 2023

Closes atsign-foundation/noports#483

- What I did

  • update exception handling for AtLookup.findSecondary()

- How I did it

  • split some very long exception messages into a log message and the rest as an exception message for more clarity
  • add special exception handling for RootServerConnectivityException in CacheableSecondaryAddressFinder
  • some more minor modifications to exception messages that are part of the finding secondary address process
  • some minor formatting of exception messages and code comments in at_auth_impl

- How to verify it

  • The updated exception message when the internet is disconnected should be Unable to authenticate | Cause: Unable to establish connection with root server. Please check your internet connection and try again

- Description for the changelog

fix: update exception handling for AtLookup.findSecondary()

@srieteja srieteja merged commit 630179c into trunk Dec 5, 2023
11 checks passed
@srieteja srieteja deleted the no_internet branch December 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: better error message when disconnected from the internet
2 participants