Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isEncrypted if set to false or true in notify command #649

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: add isEncrypted if set to false or true in notify command #649

merged 2 commits into from
Sep 12, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Sep 12, 2024 •
edited
Loading

Fixes #650
- What I did

  • Set isEncrypted flag in notify command whether it is true or false
    - How I did it
  • Temporarily introduce a private method _toAtProtocolFragment(duplicate of AtKey-->Metadata --> toAtProtocolFragment). Set isEncrypted whether it is true or false. Remove this private method and reuse AtKey method once update verb isEncrypted changes are done.
    - How to verify it
  • tests in dependent repos should pass

#646
atsign-foundation/at_server#2087
atsign-foundation/at_client_sdk#1393
#647
atsign-foundation/noports#1344

@murali-shris murali-shris changed the title feat: add isEncrypted is set to false or true in notify command feat: add isEncrypted if set to false or true in notify command Sep 12, 2024
@murali-shris murali-shris marked this pull request as ready for review September 12, 2024 06:51
gkc
gkc requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a stopgap. As a precaution, please add some unit tests re isEncrypted when using an UpdateVerbBuilder

@murali-shris
Copy link
Member Author

This is fine as a stopgap. As a precaution, please add some unit tests re isEncrypted when using an UpdateVerbBuilder

141716a
Are these tests fine ?

gkc
gkc approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murali-shris
Copy link
Member Author

I will rerun the tests once below PR is merged and then merge at_commons PR
atsign-foundation/at_client_sdk#1391

@murali-shris murali-shris merged commit e3488f7 into trunk Sep 12, 2024
11 checks passed
@murali-shris murali-shris deleted the notify_isencrypted branch September 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

at_commons - isEncrypted is set in notify command only if it is true
2 participants
@murali-shris @gkc