Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add IV params in EnrollParams and enroll verb builder #727

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix: add IV params in EnrollParams and enroll verb builder #727

merged 3 commits into from
Dec 6, 2024

Conversation

murali-shris
Copy link
Member

- What I did

  • added IV params for encryption private key and self encryption key in enroll params. This will eliminate the use of zero IVs currently used to encrypt these keys
    - How I did it
  • added the params in verb builder and enroll_params.dart. Generated enroll_params.g.dart
  • added checks to unit tests
    - How to verify it
  • tests should pass

@murali-shris
Copy link
Member Author

Merge and publish at_commons once changes are tested in at_client and server

@murali-shris murali-shris marked this pull request as ready for review December 5, 2024 13:16
@murali-shris
Copy link
Member Author

Merge and publish at_commons once changes are tested in at_client and server

@sitaram-kalluri has done the client side changes and tested with at_commons + server changes

gkc
gkc reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'd like to talk through both this PR and the other ones tomorrow before we merge

@gkc gkc merged commit b65a3dc into trunk Dec 6, 2024
12 checks passed
@murali-shris murali-shris deleted the apkam_iv_issue_fix branch December 6, 2024 11:44
@gkc gkc restored the apkam_iv_issue_fix branch December 6, 2024 12:07
@sitaram-kalluri sitaram-kalluri deleted the apkam_iv_issue_fix branch December 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @gkc