Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new "at_policy" package for building policy services on atProtocol #731

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Dec 9, 2024

- What I did

  • new package at_policy
  • added at_policy to the build / test matrix in .github workflows
  • added core unit tests

The at_policy library provides generic scaffolding for

  • building policy management services
  • with which policy enforcement endpoints communicate via atProtocol
  • using the atClient libraries
  • and therefore get all the benefits of using atProtocol and the atClient libraries - outbound communication only, end-to-end encryption, using atSigns rather than IP addresses, etc

- How I did it

  • Added core code
  • Added tests
  • Added main README
  • Added examples and a README in the examples directory

- How to verify it
Tests pass

gkc added 3 commits December 9, 2024 15:49
build: update the example package name in at_policy to `at_policy_example`
@gkc gkc requested review from XavierChanth and cpswan December 9, 2024 16:01
cpswan
cpswan previously approved these changes Dec 9, 2024
Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan to add this to the automated tests we run from at_libraries/.github/workflows/at_libraries.yaml?

@gkc
Copy link
Contributor Author

gkc commented Dec 9, 2024

What's the plan to add this to the automated tests we run from at_libraries/.github/workflows/at_libraries.yaml?

Already done

test: use PolicyService factory constructor rather than PolicyServiceImpl
@gkc
Copy link
Contributor Author

gkc commented Dec 9, 2024

@XavierChanth just noticed that I hadn't updated example/bin/service.dart to use PolicyService, which I added after the initial implementation in order to simplify the policy service development experience ... I'll update this tomorrow morning, maybe this evening although unlikely

@gkc
Copy link
Contributor Author

gkc commented Dec 9, 2024

@XavierChanth just noticed that I hadn't updated example/bin/service.dart to use PolicyService, which I added after the initial implementation in order to simplify the policy service development experience ... I'll update this tomorrow morning, maybe this evening although unlikely

Actually that's incorrect - policy.dart is using PolicyService - service.dart is not because it is the service which is calling the policy service. In a version 1.1 I may add a PolicyClient to make it easier to write clients of the policy service

XavierChanth
XavierChanth previously approved these changes Dec 9, 2024
gkc added 3 commits December 9, 2024 21:35
…ackage's `CoreDeviceInfo` class to `CoreServiceInfo` and renamed some instance variables also (device -> service)
@gkc gkc merged commit d214d0f into trunk Dec 9, 2024
13 checks passed
@gkc gkc deleted the at_policy_1 branch December 9, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants