fix: remove 'transformers' from PolicyService interface and impl #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cyService factory so they can be passed to the PolicyServiceImpl constructor
gkc
changed the title
…cyService and PolicyServiceImpl which were introduced in order to support legacy NoPorts authorization checks - this legacy support is now being handled within the NoPorts policy service
XavierChanth
approved these changes
Dec 11, 2024
| payload: PolicyResponse( | ||
| message: 'Exception: $e', | ||
| policyDetails: [], | ||
| ).toJson(), | ||
| message: 'Exception: $e', |
There was a problem hiding this comment.
Is message supposed to be there twice? I see it was moved into the payload, but also kept in response.
There was a problem hiding this comment.
Yes supposed to be there twice, thanks Xavier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
fix: removed
requestTransformerandresponseTransformerfrom PolicyService and PolicyServiceImpl which were introduced in order to support legacy NoPorts authorization checks - this legacy support is now being handled within the NoPorts policy service- How I did it
See commits
- How to verify it
Tests pass