Skip to content

Commit

Permalink
Merge pull request #111 from atsign-foundation/decisions/remove-rever…
Browse files Browse the repository at this point in the history
…se-sshnp-client

docs: Create 2023-11-remove-reverse-sshnp-client.md
  • Loading branch information
cpswan authored Nov 15, 2023
2 parents 95c78a1 + aa21ee5 commit d9fee68
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions decisions/2023-11-remove-reverse-sshnp-client.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!-- This template is inspired by https://github.com/GoogleCloudPlatform/emblem/tree/main/docs/decisions -->
## Remove Reverse SSH No Ports Client

* **Status:** Approved <!-- / Draft / Rejected / Superseded -->
* **Last Updated:** 2023-11-14
* **Objective:** To finalize the decision to remove reverse client support in SSH No Ports 4.0.0

## Context & Problem Statement

There are maintenance costs and edge cases created by supporting a reverse client as fallback when not using sshrvd with SSH No Ports.

[repo link](https://github.com/atsign-foundation/sshnoports)

## Goals

To establish whether we should support a reverse client or not, and how.

### Non-goals
N/A

## Considered Options <!-- optional -->
- ### Completely remove the reverse client
- ### Remove the reverse client and reintroduce as a completely separate implementation (later, as needed)
- ### Continue supporting the reverse client

## Proposal Summary

Recommendation: remove the reverse client for now, reintroduce it later as needed.

## Proposal in Detail

Supporting the reverse client creates a number of edge cases, and is useful for when we assume that there is no sshrvd mediating the connection.
The project is moving in the direction where sshrvd is the heart and soul of connectivity for sshnp, so there isn't a clear need for the reverse client.
Maintaining the reverse client leaves behind a bunch of additional maintenance work, since all forward clients would require either a fallback reverse
client implementation, or in some cases, reverse clients can't be supported at all (such as in mobile/sandboxed applications).

My recommendation is that we remove the reverse client for now, and reintroduce it in isolation from the forward clients if
it is deemed as a necessary implementation for a particular use-case.

### Expected Consequences <!-- optional -->

0 comments on commit d9fee68

Please sign in to comment.