feat: Use at_lookup's CacheableSecondaryAddressFinder #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make a single CacheableSecondaryAddressFinder available through the AtSecondaryServerImpl singleton - Ensure this is used everywhere else it needs to be used. Allow it to be injected where necessary - Refactor - remove the singleton nature of OutboundClientManager, and instead create it as a final instance variable in AtSecondaryServerImpl - Make AtSecondaryConfig.rootServerUrl and .rootServerPort return String and int respectively rather than String? and int?
…plements the retry behaviour)
3 tasks
cconstab
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR primarily addresses one aspect of atsign-foundation/at_libraries#368 - i.e. make at_server use the same thing as at_client which means using at_lookup's CacheableSecondaryAddressFinder. The second aspect - add retry capability to CacheableSecondaryAddressFinder - is addressed in at_libraries PR 401 which has been merged and published as at_lookup version 3.0.40 - this PR also includes a change to use at_lookup version 3.0.40
- What I did
feat: Use at_lookup's CacheableSecondaryAddressFinder
- How I did it
- How to verify it
Tests should pass