Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add unit and functional tests using Dart beta #1786

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

cpswan
Copy link
Member

@cpswan cpswan commented Feb 7, 2024

Fixes #1785

- What I did

Created new workflow to run unit tests and functional tests using Dart Beta channel

- How I did it

  • Copied at_server workflow
  • Stripped out unnecessary run conditions
  • s/stable/beta/ for Dart SDK in unit tests and functional tests
  • Removed all other tests

- How to verify it

Action will run against this PR

- Description for the changelog

ci: Add unit and functional tests using Dart beta

@cpswan cpswan requested review from gkc and sitaram-kalluri February 7, 2024 14:20
@cpswan cpswan self-assigned this Feb 7, 2024
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to reuse code from the existing workflow in the new one, rather than duplicating and editing?

@cpswan cpswan marked this pull request as draft February 7, 2024 15:31
@cpswan
Copy link
Member Author

cpswan commented Feb 7, 2024

@gkc generally YAML isn't the best for reuse.

Having discussed with @XavierChanth I'm going to see if I can do this with a matrix; so switched to draft for now.

@XavierChanth
Copy link
Member

This is a good example: multibuild/main_build:

https://github.com/atsign-foundation/noports/blob/trunk/.github/workflows/multibuild.yaml

@cpswan cpswan marked this pull request as ready for review February 7, 2024 16:00
@cpswan
Copy link
Member Author

cpswan commented Feb 7, 2024

@gkc this now uses the same approach as atsign-foundation/at_client_sdk#1236 and is ready to review

@gkc gkc merged commit b420e48 into trunk Feb 7, 2024
21 checks passed
@gkc gkc deleted the cpswan-beta-tests branch February 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add at_server tests for Dart Beta releases so we can get early warning of issues caused by breaking changes
3 participants