feat: Introduce localkey #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VJag
reviewed
Sep 26, 2022
gkc
requested changes
Sep 26, 2022
sitaram-kalluri
force-pushed
the
atkey_local
branch
3 times, most recently
from
8b6555e to
66cc729
Compare
sitaram-kalluri
force-pushed
the
atkey_local
branch
from
66cc729 to
84d11c2
Compare
gkc
requested changes
Sep 27, 2022
gkc
requested changes
Oct 9, 2022
gkc
requested changes
Oct 10, 2022
at_commons/test/at_key_test.dart
Outdated
| @@ -575,5 +575,27 @@ void main() { | |||
| expect(localKey.isLocal, true); | |||
| expect(localKey.toString(), 'local:phone@alice'); | |||
| }); | |||
|
|
|||
| test('validate a local key with namespace', () { | |||
There was a problem hiding this comment.
Test description says 'with namespace' but there is no namespace used in this test. And shouldn't the validation then fail because namespace should be mandatory? Same applies to the next test below
There was a problem hiding this comment.
@gkc, i have copied the test from above and changed the key types. missed correcting the test subject line. Since enforceNamespace defaults to false, the tests did not fail. Added a new test with enforceNamespace set to true which asserts on a failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
Introduces new key type - local.
Files Modified:
at_key.dart:
- Introduce the static method "local" that returns "LocalKeyBuilder" instance
- Added a new sub class "LocalKey" which extends AtKey to represent a local key
at_key_builder_impl.dart:
- Added class "LocalKeyBuilder" which extends "AbstractKeyBuilder"
key_type.dart:
- Added "localKey" to the enum
at_key_regex_utils.dart:
- Added regex for local key with and without enforcing the namespace
at_key_type_test.dart:
- Added unit test for local keys
- How to verify it
- Description for the changelog