Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement the == and hashCode methods for AtKey, AtValue and Metadata classes #241

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Oct 15, 2022

- What I did

  • Implemented the == and hashCode methods for AtKey, AtValue and Metadata classes

- Why I did it

  • Needed a way to assert that a List contains another AtKey. Simplest possible way of achieving that is to override the default == and hashCode methods for the AtKey and Metadata classes. As I was doing it for those two classes, I decided to do it for AtValue also.

- How I did it

  • Added the IDE-generated implementations without modifiations

- How to verify it

- Description for the changelog

  • feat: Implement the == and hashCode methods for AtKey, AtValue and Metadata classes

@gkc
Copy link
Contributor Author

gkc commented Oct 16, 2022

Test runs have succeeded in at_client_sdk and at_server when using this branch. Merging.

@gkc gkc merged commit 7664de1 into trunk Oct 16, 2022
@gkc gkc deleted the add_==_and_hashCode_to_AtKey branch October 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants