Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension KHR_materials_transmission #111

Open
atteneder opened this issue Nov 24, 2020 · 4 comments
Open

Extension KHR_materials_transmission #111

atteneder opened this issue Nov 24, 2020 · 4 comments
Labels
enhancement New feature or request extension involves a glTF extension material material/shader features

Comments

@atteneder
Copy link
Owner

atteneder commented Nov 24, 2020

Add support for KHR_materials_transmission

Full support is planned/investigated for Universal Render Pipe and High Definition Render Pipe.

The Built-In Render Pipe will receive an approximation solution without transmission roughness nor transmission texture support. It'll work for clear glass (100% transmission + white baseColor), but will fall back to a blended approximation for tinted glass.

@atteneder atteneder added enhancement New feature or request extension involves a glTF extension labels Nov 24, 2020
@atteneder atteneder added this to the 3.0.0 milestone Dec 9, 2020
atteneder added a commit that referenced this issue Dec 9, 2020
…nder pipeline (glTF extension KHR_materials_transmission; #111)
@atteneder atteneder modified the milestones: 3.0.0, 4.0.0 Mar 1, 2021
@atteneder atteneder modified the milestones: 4.0.0, 5.0.0 May 3, 2021
@ponahoum
Copy link

ponahoum commented Nov 1, 2021

Would be nice that have this feature added, with the support of this for tests: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/TransmissionTest

@atteneder is this planned in the short term?

@atteneder
Copy link
Owner Author

@ponahoum

There are approximations and make-shift solutions in place already. You can find the details in the material import section of the feature document.

Are those good enough for your use-cases and if not, why not?

Which render pipeline do you intend to use it with?

hth

@ponahoum
Copy link

ponahoum commented Nov 1, 2021

@atteneder it seems that it works for my use case (which is simply to import a glass-window gltf) but I must manually set the blend mode to transparent to make it work. I thought it would do it automatically on import.

@atteneder
Copy link
Owner Author

@ponahoum It definitely should work out of the box! I've made some material fixes recently. Could you please test again and open a new issue if the problem persists? Thanks!

@atteneder atteneder added the material material/shader features label Dec 1, 2021
@atteneder atteneder removed this from the 5.0.0 milestone May 31, 2022
atteneder added a commit to Unity-Technologies/com.unity.cloud.gltfast that referenced this issue Apr 9, 2024
…ST_EDITOR_IMPORT_OFF` scripting define). glTF assets have been replaced with mesh assets. (atteneder#111)
@atteneder atteneder moved this to Extensions in glTFast development Jun 25, 2024
@atteneder atteneder moved this from Extensions to Planned in glTFast development Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension involves a glTF extension material material/shader features
Projects
Status: Planned
Development

No branches or pull requests

2 participants