Add: None + Mecanim animation clip import #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! (I imagined it to work something like that as well) I'll be back from vacation next week, I'll have a detailed look then. Thanks ❤️ |
|
@hybridherbst as always, thanks a lot ❤️ This paves the way for better animation, like #166 |
atteneder
added a commit
to Unity-Technologies/com.unity.cloud.gltfast
that referenced
this pull request
Dec 16, 2024
…o subfolder. (atteneder#190) * refactor: Moved package content into sub-folder `Packages/com.unity.cloud.gltfast`. * feat: Added global README. * refactor: Adopting CI scripts to new monorepo structure. * refactor: Moved package tests to dedicated tests package. * feat: Added test projects to be used for development and testing. * fix: RenderPipelineAssets reside in tests package now. * fix: Declare related package. * doc: Added built-in modules to the installation docs. * doc: Added development docs. * feat(ci): Static analysis * chore: Updated test dependencies. * fix: Changelog markdown structure fix * fix: XML doc additions and fixes. * fix: Removed unnecessary "type" property from `package.json`. * fix: Removed warning about obsolete `GraphicsDeviceType.OpenGLES2` in Unity 2023.1 or newer. * fix(export): Missing texture transform if texture on glTFast material was scaled vertically only. * fix: Moving PNG image file to GIT LFS by fixing extension to being lowercase now. * chore: Removed outdated and unused code coverage badge. * refactor: Code examples (atteneder#194) * refactor: Moved code examples that are referenced by the documentation into a different folder (`DocExamples`). * refactor: Renamed code example assembly to `glTFast.Documentation.Examples` and namespace to `GLTFast.Documentation.Examples` for consistency. * chore: Removed outdated API documentation filters. * fix: Exclude documentation example code from code coverage. * fix: Image file name changed (`Images/gltf-extra-data.png`). * feat(ci): Package Verification Profile checks and tooling. (atteneder#195) * feat: Added PVP check to pack job. * feat(ci): Replaced upm-ci with upm-pvp/UTR for packing, package tests, player tests and publishing. * API validation is still done via upm-ci. * refactor: Merged jobs `build_and_run_*` into `run_*` to remove redundant scripts. * feat(ci): Automated publish and dry run publish jobs. * feat(ci): PR trigger comment `pr` for PRs that don't target `main`/`develop` branch. * fix: Various issues reported by static analysis. (atteneder#196) * fix: Improved reliability by adding null checks and imprecision-aware floating-point comparisons in various places. * fix: Async methods return a `Task` type where feasible. * fix: Using immutable fields only in hash calculation for `ImageExport` classes. * refactor: Renamed property ImageExport.ValidAssetPath to be pascal case. * fix(export): Consolidate textures based on dedicated comparison (`TextureComparer.Equals`) instead of problematic equality implementation. * refactor: Replaced `GetHashCode` implementation referencing mutable fields with default fallback to avoid potential unexpected behavior. * refactor: `MeshPrimitiveComparer` is now used for clustering mesh primitives (instead of `GetHashCode`/`Equals` on `MeshPrimitive` and sub-types). * chore(ci): Renamed variable to avoid confusion between project key and name. * fix(ci): Use GIT branch as version * chore(ci): Use repository relative paths for reports. * chore: Updated code coverage exclusion paths. * doc: Added missing changelog entry. * doc: Explicitly mention lack of morph target export support. * fix(ci): Ensure all jobs succeeds with Windows and 2020 LTS. * feat(ci): Ported sonarscanner script from macOS to Windows to unify it with code coverage jobs. * feat(test): Package coherence tests that make sure package versions match across exported generator string and documentation. (atteneder#197) * fix: Set minimum required Unity version to 2020.3.48f1 in the documentation. * doc: Developer onboarding (atteneder#198) * chore: Bumped package versions * fix(ci): Consistently repeat once after a failed run for all test jobs. * chore(ci): Disabled `enablePackageManagerTraces` * chore: Removed obsolete vscode pkg. * fix(export): Avoid potential loss of data by allocating output streams persistently. * feat(test): Added glTF assets for testing (atteneder#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing in the editor, it's not always desired to have legacy clips. This PR adds "None" and "Mecanim" as import options.
There's some commented code that attempts to import an AnimatorController + StateMachine as well, but it seems that isn't supported (?) from a ScriptedImporter as it would require adding StateMachine subassets to the AnimatorController subasset.
A workaround (not yet implemented here) would be to have an "Extract AnimatorController" button that creates and connects an AnimatorController as externalObjectMapping.