Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidatorOpts does not implement status parameter #103

Closed
pinebit opened this issue Feb 1, 2024 · 2 comments
Closed

ValidatorOpts does not implement status parameter #103

pinebit opened this issue Feb 1, 2024 · 2 comments

Comments

@pinebit
Copy link
Contributor

pinebit commented Feb 1, 2024 •
edited
Loading

In according to the spec, /eth/v1/beacon/states/{state_id}/validators query provides id and status arrays. However, the current implementation ignores status
https://github.com/attestantio/go-eth2-client/blob/master/api/validatorsopts.go#L19

Would it be possible and easy to make it matching the spec?
@pinebit pinebit mentioned this issue Feb 1, 2024
Closed
2 tasks
@mcdee
Copy link
Contributor

mcdee commented Feb 11, 2024

There was a PR #78 that added this, but it needs to be rebased against current master before continuing. Not sure if the owner of that PR is still interested in the functionality or not.

@mcdee
Copy link
Contributor

mcdee commented Feb 29, 2024

This has been added to latest master.

@mcdee mcdee closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcdee @pinebit