Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beacon block reward endpoint #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions api/beaconblockrewardopts.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright © 2023 Attestant Limited.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package api

// BeaconBlockHeaderOpts are the options for obtaining beacon block headers.
type BeaconBlockRewardOpts struct {
Common CommonOpts

// Block is the ID of the block which the data is obtained.
Block string
}
146 changes: 146 additions & 0 deletions api/v1/beaconblockreward.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
// Copyright © 2020, 2021 Attestant Limited.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package v1

import (
"encoding/json"
"fmt"
"strconv"

"github.com/pkg/errors"
)

// BeaconBlockReward Rewards info for a single block
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you fix comments so that they end in a period? Thanks.

type BeaconBlockReward struct {
// Proposer of the block, the proposer index who receives these rewards
ProposerIndex uint64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be of type phase0.ValidatorIndex

// Total block reward in gwei, equal to attestations + sync_aggregate + proposer_slashings + attester_slashings
Total uint64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other gwei values should be of type phase0.Gwei

// Block reward component due to included attestations in gwei
Attestations uint64
// Block reward component due to included sync_aggregate in gwei
SyncAggregate uint64
// Block reward component due to included proposer_slashings in gwei
ProposerSlashings uint64
// Block reward component due to included attester_slashings in gwei
AttesterSlashings uint64
}

// beaconBlockRewardJSON is the spec representation of the struct.
type beaconBlockRewardJSON struct {
ProposerIndex string `json:"proposer_index"`
Total string `json:"total"`
Attestations string `json:"attestations"`
SyncAggregate string `json:"sync_aggregate"`
ProposerSlashings string `json:"proposer_slashings"`
AttesterSlashings string `json:"attester_slashings"`
}

// MarshalJSON implements json.Marshaler.
func (b *BeaconBlockReward) MarshalJSON() ([]byte, error) {
return json.Marshal(&beaconBlockRewardJSON{
ProposerIndex: fmt.Sprintf("%d", b.ProposerIndex),
Total: fmt.Sprintf("%d", b.Total),
Attestations: fmt.Sprintf("%d", b.Attestations),
SyncAggregate: fmt.Sprintf("%d", b.SyncAggregate),
ProposerSlashings: fmt.Sprintf("%d", b.ProposerSlashings),
AttesterSlashings: fmt.Sprintf("%d", b.AttesterSlashings),
})
}

// UnmarshalJSON implements json.Unmarshaler.
func (b *BeaconBlockReward) UnmarshalJSON(input []byte) error {
var err error

var beaconBlockRewardJSON beaconBlockRewardJSON
if err = json.Unmarshal(input, &beaconBlockRewardJSON); err != nil {
return errors.Wrap(err, "invalid JSON")
}

return b.unpack(&beaconBlockRewardJSON)
}

func (b *BeaconBlockReward) unpack(beaconBlockRewardJSON *beaconBlockRewardJSON) error {
if beaconBlockRewardJSON.ProposerIndex == "" {
return errors.New("proposer index missing")
}

proposerIndex, err := strconv.ParseUint(beaconBlockRewardJSON.ProposerIndex, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for proposer index")
}
b.ProposerIndex = proposerIndex

if beaconBlockRewardJSON.Total == "" {
return errors.New("total missing")
}

total, err := strconv.ParseUint(beaconBlockRewardJSON.Total, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for total")
}
b.Total = total

if beaconBlockRewardJSON.Attestations == "" {
return errors.New("total missing")
}

attestations, err := strconv.ParseUint(beaconBlockRewardJSON.Attestations, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for attestations")
}
b.Attestations = attestations

if beaconBlockRewardJSON.SyncAggregate == "" {
return errors.New("sync aggregate missing")
}

syncAggregate, err := strconv.ParseUint(beaconBlockRewardJSON.SyncAggregate, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for sync aggregate")
}
b.SyncAggregate = syncAggregate

if beaconBlockRewardJSON.ProposerSlashings == "" {
return errors.New("proposer slashing missing")
}

proposerSlashings, err := strconv.ParseUint(beaconBlockRewardJSON.ProposerSlashings, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for proposer slashings")
}
b.ProposerSlashings = proposerSlashings

if beaconBlockRewardJSON.AttesterSlashings == "" {
return errors.New("proposer slashing missing")
}

attesterSlashings, err := strconv.ParseUint(beaconBlockRewardJSON.AttesterSlashings, 10, 64)
if err != nil {
return errors.Wrap(err, "invalid value for attester slashings")
}
b.AttesterSlashings = attesterSlashings

return nil
}

// String returns a string version of the structure.
func (b *BeaconBlockReward) String() string {
data, err := json.Marshal(b)
if err != nil {
return fmt.Sprintf("ERR: %v", err)
}

return string(data)
}
55 changes: 55 additions & 0 deletions http/beaconblockreward.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Copyright © 2020 - 2024 Attestant Limited.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package http

import (
"bytes"
"context"
"fmt"

client "github.com/attestantio/go-eth2-client"
"github.com/attestantio/go-eth2-client/api"
apiv1 "github.com/attestantio/go-eth2-client/api/v1"
)

// BeaconBlockHeader provides the block header given the opts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you fix this comment to match the function.

func (s *Service) BeaconBlockReward(ctx context.Context,
opts *api.BeaconBlockRewardOpts,
) (
*api.Response[*apiv1.BeaconBlockReward],
error,
) {
if err := s.assertIsActive(ctx); err != nil {
return nil, err
}
if opts == nil {
return nil, client.ErrNoOptions
}

endpoint := fmt.Sprintf("/eth/v1/beacon/rewards/blocks/%s", opts.Block)
httpResponse, err := s.get(ctx, endpoint, "", &opts.Common, false)
if err != nil {
return nil, err
}

data, metadata, err := decodeJSONResponse(bytes.NewReader(httpResponse.body), apiv1.BeaconBlockReward{})
if err != nil {
return nil, err
}

return &api.Response[*apiv1.BeaconBlockReward]{
Metadata: metadata,
Data: &data,
}, nil
}
14 changes: 9 additions & 5 deletions http/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"math/rand"
"net"
"net/http"
"net/url"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you revert the changes to this file, as they have been addressed elsewhere.

"strings"
"time"

Expand Down Expand Up @@ -53,12 +54,15 @@ func (s *Service) Events(ctx context.Context, topics []string, handler consensus
}
}

endpoint := "/eth/v1/events"
query := "topics=" + strings.Join(topics, "&topics=")
callURL := urlForCall(s.base, endpoint, query)
log.Trace().Str("url", callURL.String()).Msg("GET request to events stream")
reference, err := url.Parse(fmt.Sprintf("eth/v1/events?topics=%s", strings.Join(topics, "&topics=")))
if err != nil {
return errors.Join(errors.New("invalid endpoint"), err)
}

callURL := fmt.Sprintf("%s/%s", s.base.String(), reference)
log.Trace().Str("url", callURL).Msg("GET request to events stream")

client := sse.NewClient(callURL.String())
client := sse.NewClient(callURL)
for k, v := range s.extraHeaders {
client.Headers[k] = v
}
Expand Down