Add more unified getters for common block properties #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mcdee
requested changes
Sep 23, 2023
spec/versionedsignedbeaconblock.go
Outdated
| } | ||
| } | ||
|
|
||
| func (v *VersionedSignedBeaconBlock) Graffiti() ([]byte, error) { |
There was a problem hiding this comment.
The return value should be [32]byte to match the underlying data type.
|
fixed :) |
mcdee
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more unified getters for common block properties to the
VersionedSignedBeaconBlockstruct:Fixed
VersionedSignedBeaconBlock.ExecutionBlockHash(), which was using the bellatrix struct regardless of the actual block type and therefore fails with a nil pointer for non-bellatrix blocks