-
Notifications
You must be signed in to change notification settings - Fork 266
The root chunk is huge #2869
Comments
See also #2848 |
@arv can you estimate difficulty for this? |
It makes attic UI load slowly, but it's somewhat of a temporary problem that will be addressed by other work we have planned. |
Also, would it be a serialization change? |
Update: I realize this might be easier because the type of this map should be |
@rafael-atticlabs, @arv, @cmasone-attic seems like would be best options for this, but I think @rafael-atticlabs has least on his plate. Can you take it? |
Here is an example of a huge root chunk (16MB) from the laudman db. I'm going to delete some things from this so I wanted to preserve the horribleness for investigation.
This chunk is a
|
Since the head of each dataset can have an arbitrarily complex type, type accretion leads the Datasets map at the root of the DB to become very large. This type info isn't really very useful at that level either. So, get rid of it by making this map be from String -> Ref<Value>. Fixes attic-labs#2869
Since the head of each dataset can have an arbitrarily complex type, type accretion leads the Datasets map at the root of the DB to become very large. This type info isn't really very useful at that level either. So, get rid of it by making this map be from String -> Ref<Value>. Fixes attic-labs#2869
Since the head of each dataset can have an arbitrarily complex type, type accretion leads the Datasets map at the root of the DB to become very large. This type info isn't really very useful at that level either. So, get rid of it by making this map be from String -> Ref<Value>. Fixes #2869
Currently the root map encodes the type of every dataset. Clients must download this chunk even though nobody ever really uses it.
I think that the thing to do here is to just change Noms to have this root map have the type
Map<string, Ref<Value>>
.The text was updated successfully, but these errors were encountered: