Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Replace regexp with loop for struct name/field validation #3736

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Replace regexp with loop for struct name/field validation #3736

merged 1 commit into from
Sep 22, 2017

Conversation

arv
Copy link
Contributor

@arv arv commented Sep 22, 2017

Fixes #2866

@arv arv requested a review from a user September 22, 2017 18:30
@ghost
Copy link

ghost commented Sep 22, 2017

LGTM. Can you verify that this at least didn't regress perf? Try profiling a noms serve and then write to it (e.g. with csv-import). This verification path should be invoked then.

@arv
Copy link
Contributor Author

arv commented Sep 22, 2017

Verified. It showed up before and doesn't show up any more.

@arv arv merged commit 2cd5664 into attic-labs:master Sep 22, 2017
@arv arv deleted the struct-name-validation branch September 22, 2017 20:06
@ghost
Copy link

ghost commented Sep 22, 2017

Nice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arv