Add support for Ruby 2.7 and its kwargs #383
Conversation
|
@saghaulor wdyt about these changes? could you please have a look? We can just fix the kwargs warning in this PR and continue the discussion on testing against Ruby versions in #364 |
|
Hitting this problem now when upgrading to ruby 3. Thanks for the fix @igor-drozdov! Would be awesome to merge this |
|
@benguillet the project seems to be not actively maintained 😓 the workaround we went for in this particular case was using |
|
That's smart! I ended up forking the gem to implement your fix and it's working great. I think eventually we'll move to the new rails 7 included way of encrypting fields, but for now it does the trick! |
|
@mvastola Are you the new maintainer ? Perhaps you can help look at this PR ? |
|
@igor-drozdov would you like to rebase master onto your branch and just fix the one kwarg deprecation? Master should be in a passing state now and tests Ruby 2.6 and 2.7. If not let me know and I can open a PR as well, but want to give you a chance. I know it has been a while! |
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0.
igor-drozdov
force-pushed
the
ruby-2-7-support
branch
from
b5e2d26
to
1a629e8
Compare
|
@joshbranham thanks for reviewing! |
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0. Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0. Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0. Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0.