-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.0 #455
Release 1.3.0 #455
Conversation
hagenw
commented
Jul 15, 2024
•
edited
Loading
edited
This is a breaking change release as code that expects a table to be stored as a csv file will break. But as around 99% of use cases will not directly try to access the csv files, but use |
-------------------------- | ||
|
||
* Added: ``strict`` argument | ||
to ``audformat.utils.hash()``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a full stop at the end of the sentence. The others do not. What is convention that we are using here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention is to not use a full stop at the last sentence in an entry. But for earlier ones we use a full stops:
* Added: ``strict`` argument
to ``audformat.utils.hash()``.
If set to ``True``,
the order of the data,
and its level/column names
are taken into account
when calculating the hash
As you can see the last hash
has no full stop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me content-wise.
I have one question about interpuntuation, but that is not a blocker for giving approval.
|