Release 1.3.1 #458
Merged
Release 1.3.1 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ChristianGeng <christian.c.geng@gmail.com>
ChristianGeng
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
The package used until now is deprecated with the latest release 8 years old:
https://pypi.org/project/iso639/#history
My basic understanding is that the proposed package is a good choice for replacement. There would be another candidate python-iso639.
Interestingly both python-iso639 and the one we are going for iso639-lang seem to be releasing at almost the same dates:
https://pypi.org/project/iso639-lang/#history
https://pypi.org/project/python-iso639/#history
This to me suggests that both are tracking changes in the iso-639 definitions quite closely and make for good replacements.
For a review I simply verfified that tests are passing.
Therefore I am approving this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a nice contribution in #456, which changed the ISO639 package we are using to a better maintained one. As this also fixes the handling of
audformatbypoetryI would vote to do an immediate bug fix release.