Warning about password hashing

audreyfeldroy · Aug 1, 2024 · 44f0270 · 44f0270
1 parent dcbda4c
commit 44f0270
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/nbs/2024-07-29-Auth.ipynb b/nbs/2024-07-29-Auth.ipynb
@@ -96,7 +96,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 22,
+   "execution_count": 23,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -108,6 +108,9 @@
     "    }\n",
     "    expected_p = users.get(u)\n",
     "    if expected_p is None: return None\n",
+    "\n",
+    "    # WARNING: Toy implementation, not secure\n",
+    "    # Pretend we are comparing Argon2 or PBKDF2 hashes\n",
     "    return p == expected_p\n",
     "\n",
     "auth = user_pwd_auth(lookup=user_lookup)\n",