Replace executables with link to demos readme #395

Voldivh · 2023-06-02T17:27:40Z

This PR addresses an item from #366 and continues the effort made in #365.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

clalancette · 2023-06-06T14:13:57Z

requirements/features-executable-from-links.yaml

@@ -8,6 +8,51 @@ requirements:
        url: https://github.com/ros2/demos/blob/iron/composition/README.md
    checks:
      - name: The executables in the README and present and work as expected.
+  - name: Demo Nodes (CPP) executables


Suggested change

- name: Demo Nodes (CPP) executables

- name: Demo Nodes (C++) executables

clalancette · 2023-06-06T14:14:41Z

requirements/features-executable-from-links.yaml

+      - executable
+      - feature
+    links:
+      - name: Nodes cpp demos


Suggested change

- name: Nodes cpp demos

- name: Demo Nodes C++

clalancette · 2023-06-06T14:14:49Z

requirements/features-executable-from-links.yaml

+      - name: Nodes cpp demos
+        url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp/README.md
+    checks:
+      - name: The executables in the README and present and work as expected.


Suggested change

- name: The executables in the README and present and work as expected.

- name: The executables in the README are present and work as expected.

Thanks! I noticed that statement appears (exactly the same) on all the other test cases, I'll go ahead and do the corresponding modification.

clalancette · 2023-06-06T14:14:58Z

requirements/features-executable-from-links.yaml

+        url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp/README.md
+    checks:
+      - name: The executables in the README and present and work as expected.
+  - name: Demo Nodes Native (CPP) executables


Suggested change

- name: Demo Nodes Native (CPP) executables

- name: Demo Nodes Native (C++) executables

clalancette · 2023-06-06T14:15:15Z

requirements/features-executable-from-links.yaml

+      - executable
+      - feature
+    links:
+      - name: Nodes cpp native demos


Suggested change

- name: Nodes cpp native demos

- name: Demo Nodes C++ native

clalancette · 2023-06-06T14:15:32Z

requirements/features-executable-from-links.yaml

+      - name: Dummy Map Server
+        url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_map_server/README.md#run
+    checks:
+      - name: The executables in the README and present and work as expected.


Suggested change

- name: The executables in the README and present and work as expected.

- name: The executables in the README are present and work as expected.

clalancette · 2023-06-06T14:15:40Z

requirements/features-executable-from-links.yaml

+      - name: Dummy Sensors
+        url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_sensors/README.md#run
+    checks:
+      - name: The executables in the README and present and work as expected.


Suggested change

- name: The executables in the README and present and work as expected.

- name: The executables in the README are present and work as expected.

clalancette · 2023-06-06T14:15:50Z

requirements/features-executable-from-links.yaml

+        url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_sensors/README.md#run
+    checks:
+      - name: The executables in the README and present and work as expected.
+  - name: Image-tools executables


Suggested change

- name: Image-tools executables

- name: Image Tools executables

clalancette · 2023-06-06T14:16:02Z

requirements/features-executable-from-links.yaml

+      - executable
+      - feature
+    links:
+      - name: Image-tools demos


Suggested change

- name: Image-tools demos

- name: Image Tools

clalancette · 2023-06-06T14:16:08Z

requirements/features-executable-from-links.yaml

+      - name: Image-tools demos
+        url: https://github.com/ros2/demos/blob/iron/image_tools/README.md#run
+    checks:
+      - name: The executables in the README and present and work as expected.


Suggested change

- name: The executables in the README and present and work as expected.

- name: The executables in the README are present and work as expected.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Voldivh · 2023-06-06T14:34:05Z

@clalancette All comments have been addressed.

* Replace executables with link to demos readme Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

* move humble requirements to root Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update tier 3 os labels and remove source from jammy Signed-off-by: Yadunund <yadunund@openrobotics.org> * Tmp fix for redirected links in sitemap that cause duplicate requirements Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added an expectation for param delete Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix prompt for service find Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update bag info with mcap Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added details for component cli tests Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add checks for ros1_bridge Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added tests for service introspection Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add check for asunc_param_client Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix duplicate py checks Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add DISTRO_LABEL constant Signed-off-by: Yadunund <yadunund@openrobotics.org> * Use DISTRO const to retrieve docs Signed-off-by: Yadunund <yadunund@openrobotics.org> * Change the names of launch files to be _launch.py (#347) This matches the current best practice, which we updated in Iron. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Update the service executables demon_nodes_py test to use async. (#348) There is no '_sync' version, so this must have been a typo for the '_async' version, which does exist. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add the holonomic parameter to turtlesim tests. (#350) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * remove extra slash to output correct command (#353) Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix input (#352) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add linux label to realtime tests (#351) Signed-off-by: Yadunund <yadunund@openrobotics.org> * tag linux (#357) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix up the multicast test to have a try and expect section. (#355) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add in a missing component container name in a test. (#354) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Specify frame ids for static transform publisher (#358) Signed-off-by: Yadunund <yadunund@openrobotics.org> * Replace executables with link to demos readme (#365) * Replace executables with link to demos readme Signed-off-by: Yadunund <yadunund@openrobotics.org> * address feedback Signed-off-by: Yadunund <yadunund@openrobotics.org> --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> * Change references to humble -> iron (#370) Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Modifies the console input to test out rqt (#374) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds the label to only test in linux gazebo_ros_pkgs (#392) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Removes test cases for Windows (#394) Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds a clearer description for the idl message generation (#390) * Adds a clearer description of the test Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Replace executables with link to demos readme (#395) * Replace executables with link to demos readme Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Adds the full path to the launch testing stdin (#393) * Adds the full path to the launch testing stdin * Adds instructions to clone the repository Signed-off-by: Voldivh <eloyabmfcv@gmail.com> * Filter redirects in docs.ros.org sitemap (#405) * Ignore redirects Signed-off-by: Yadunund <yadunund@openrobotics.org> * Moved iron requirements to ros2_test_cases Signed-off-by: Yadunund <yadunund@openrobotics.org> * Restore garden backup Signed-off-by: Yadunund <yadunund@openrobotics.org> * Parse YAML_DISTRO_LABEL Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update readme and ci Signed-off-by: Yadunund <yadunund@openrobotics.org> * Format Signed-off-by: Yadunund <yadunund@openrobotics.org> * Make YATM_DISTRO_LABEL a required param Signed-off-by: Yadunund <yadunund@openrobotics.org> --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Voldivh <eloyabmfcv@gmail.com> Co-authored-by: Yadunund <yadunund@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>

Replace executables with link to demos readme

546c222

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

clalancette requested changes Jun 6, 2023

View reviewed changes

Modifies text messages for checks and names

0eebf72

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

clalancette approved these changes Jun 6, 2023

View reviewed changes

clalancette merged commit a97e665 into audrow:iron Jun 6, 2023

Voldivh deleted the voldivh/modifies_executables_with_links branch June 6, 2023 20:17

Yadunund mentioned this pull request Jun 12, 2023

Improvements to make from Iron Tutorial party #366

Open

19 tasks

Yadunund pushed a commit that referenced this pull request Jun 20, 2023

Replace executables with link to demos readme (#395)

3039460

* Replace executables with link to demos readme Signed-off-by: Voldivh <eloyabmfcv@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace executables with link to demos readme #395

Replace executables with link to demos readme #395

Voldivh commented Jun 2, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

Voldivh Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

clalancette Jun 6, 2023

Voldivh commented Jun 6, 2023

	- name: Demo Nodes (CPP) executables
	- name: Demo Nodes (C++) executables

	- name: The executables in the README and present and work as expected.
	- name: The executables in the README are present and work as expected.

	- name: Demo Nodes Native (CPP) executables
	- name: Demo Nodes Native (C++) executables

	- name: Image-tools executables
	- name: Image Tools executables

Replace executables with link to demos readme #395

Replace executables with link to demos readme #395

Conversation

Voldivh commented Jun 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Voldivh commented Jun 6, 2023