Update dependencies to latest upstream (notably winit -> 0.30, wgpu -> 0.20, accesskit -> 0.16) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll release a new version of vger to crates.io :) |
|
Oh whoops I did 0.2.9 for vger thinking that its own API didn't change. Guess I'll do a 0.3 now |
|
Ok 0.3.0 is up (I yanked 0.2.9). Go ahead and update your PR :) |
|
Updated :) |
|
Hey @maaku, if you run the |
|
I didn't realize in the refactor that the keyboard events are only passed on when the event is a key press. Fixed. I can rebase when it's ready for merge. |
|
Seems good now! After your rebase is it ready to merge? |
|
Yeah, ready for merge. I just force-pushed a rebased fix. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in a vger-rs pull request, I'm currently investigating use of rui for a cross-platform application supporting desktop + mobile + web, and built on winit and wgpu. This brings rui's dependencies up to the latest released version, which are the same I'm using in my app.
Note the diff is quite large! The winit API in particular changed significantly between 0.28 and 0.30. I've tried to keep the same business logic, and the API is unchanged even though some upstream improvements might want to be reflected in rui's API.
Of particular note, the way winit handles keyboard input has been completely rewritten and supports significantly more than is exposed by rui. I have updated the
rui()application runner to use these new APIs, but with the same old exposed input interface. One area in which this might actually be an issue is with multi-code-point character input. Rui's API sends a single character per keystroke, whereas winit sends a string. This is because some characters in some input schemes may not reduce down to a single Unicode glyph, instead using combining character codes. The new interface (which uses winit to do key -> character transformation rather than hard coding it as rui did before) will just send on only the first Unicode code point.Also: the vger dependency is hard-coded to the latest trunk commit as of the time of this writing, rather than a proper crates.io release. Vger should probably have a 0.3 release (since updating wgpu is breaking for downstream apps), and then rui semver-pegs to that.