Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting positions and convergence calculation #111

Merged
merged 1 commit into from
Aug 6, 2017

Conversation

milcktoast
Copy link
Contributor

Fixes resetting convergence calculations for the following use case:

  • draw first image to canvas
  • begin convergence with start()
  • wait for convergence or call stop()
  • draw second image to canvas
  • call reset() followed by start()

Without this change the previous convergence value would persist after reset and cause subsequent attempts to find a face in new images to fail.

@auduno auduno merged commit eef49d2 into auduno:dev Aug 6, 2017
@auduno
Copy link
Owner

auduno commented Aug 6, 2017

Thanks for the PR and sorry for the late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants