Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Refactor #85

Closed
wants to merge 78 commits into from
Closed

Large Refactor #85

wants to merge 78 commits into from

Conversation

yofreke
Copy link
Contributor

@yofreke yofreke commented Sep 19, 2016

Some of this is done, some is still in progress. We are using clmtrackr internally for a project, so we thought some of the changes might be appreciated upstream.

Todo:

  • Move missing examples from gh-pages in to react
  • Move docs from gh-pages to react
  • Figure out why newer models (found on gh-pages) cause tracker to lose face after ~1s
  • Finish ES6ing + linting classes

andyinabox and others added 30 commits January 23, 2016 14:50
- add worker-loader, use inline option
- format jsfeat_detect.worker.js to match worker-loader expectations
- use correct jsfeat version (package.json was using a version that is too new)
- ignore intermediate `dist/*.worker.js` in gitignore
@Skylion007
Copy link
Contributor

Build script fails on Windows:

Failed at the clmtrackr@0.0.1 build script 'NODE_ENV=production jsio-webpack'

Alas this is not proper syntax for environmental variables in Windows. :(

@jdaily
Copy link

jdaily commented Nov 19, 2016

It seem's this also fails when installing as an electron dependency Node.js 6.5.0, Chromium 53.0.2785.143, and Electron 1.4.7

@yofreke
Copy link
Contributor Author

yofreke commented Nov 19, 2016

Hey guys, thanks for the interest! This was for a project at work, but we have shelved it for the time being. I would be totally willing to collaborate on this some more in the future, but cannot spare the time right now. It uses another internal project called jsio-webpack (which is just a webpack config helper) that sees regular backwards-incompatible updates, so I cannot even say for certain that it would build on a posix box right now. Probably just some minor tweaks, but I have no idea.

We will definitely keep this PR updated if we have the time to come back and work on this some more!

@auduno
Copy link
Owner

auduno commented Jul 5, 2017

Hi! Thanks very much for the PR! Parts of this PR has now been manually merged into master with this commit. Github does not manage to resolve that to this pull request, so I'll have to close this manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants