Face Detection Cleanup and Options #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions for controlling detection
|
Sorry about the delay, finally got around to merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Audun, thanks again for this great library!
I noticed that the way jsfeat face detection is done can create some problems. For example: lots of initializations of small faces, or initialization of faces in areas with no details.
I grabbed the most recent jsfeat haar demo and rewrote
jsfeat-detect.jsto match it. This fixes the small initializations by using a small working canvas for doing the detection. I also added more parameters (all inside the params.faceDetection object) which allows the ability to turn on canny edge detection for face detection, which reduces initialization of faces in areas with no details. These options also close #89 by allowing the user to limit the size of faces that are detected.Finally, I also updated jsfeat and added a note to the readme about the development environment.
Thanks!