Fix for #3 and #5 issues #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I will check the changes and test them today. If everything ok, I will make a release. Thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Eldes token expire very fast. Need refresh it every time before requests to API. If get error need relogin. Existing token can expire or you can login over cloud website with same account. All old tokens will be revoked.
After arm or disarm you must wait status from API and do not change localy. If you arm but some sensor trigered eldes reject action. Eldes do not have arming and disarming. if you try arm and if fails you get just disarm. In eldes app you get info about sensor problem and ask to disable it.
I tested more than one week and works without problems. I use 15sec sync interval.