Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screen corners appear in the right place on multi-screen systems #5

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

lunaneff
Copy link
Contributor

@lunaneff lunaneff commented Feb 19, 2022

Fixes #2, partially #4

I also tried fixing #3, but it looks like panel_corners.js is currently completely broken, as when I commented out the rendering code in screen_corner.js I didn't see any rounded corners (even in the overview). I wasn't really able to understand how it's supposed to work, so I can't fix that

edit: actually, it looks like panel corners do work, but only on Wayland (and I didn't notice because I used Xorg so I can reload without relogging)

edit 2: actually no, I accidentally rebooted into an ostree deployment which is still on gnome-shell 41

@aunetx
Copy link
Owner

aunetx commented Feb 21, 2022

Thank you very much, I don't have an external monitor to test it; however it looks like exactly the right thing to do here.

What do you mean by fixing partially #4? Is there still any issue after this PR?

And for #3, I will see what I can do; however I don't fully understand the issue. Thanks you very much!

@aunetx aunetx merged commit 3eb0ec5 into aunetx:master Feb 21, 2022
@lunaneff
Copy link
Contributor Author

To be honest, when I created #4, I didn't properly look at #2 and #3, so I basically made a single issue about both.

I'm pretty sure the issue with #3 is that there are no corners below the panel, unlike gnome-shell pre-42:

image

@aunetx
Copy link
Owner

aunetx commented Feb 21, 2022

Uh that's not expected at all... Does it work when you use only one monitor?

@lunaneff
Copy link
Contributor Author

lunaneff commented Feb 21, 2022

Nope, a single monitor doesn't work either

Distro is Fedora Silverblue Rawhide, build from 2022-02-20, gnome-shell 42.beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen corners drawn on top of each other on multiple monitors
2 participants