Fix 404s on Rustdocs for auraed
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccormickt
commented
Jan 14, 2024
| @@ -315,7 +315,7 @@ endif | |||
|
|
|||
| .PHONY: docs-crates | |||
| docs-crates: musl $(GEN_TS) $(GEN_RS) ## Build the crate (documentation) | |||
| $(cargo) doc --target $(uname_m)-unknown-linux-musl --no-deps --package auraed | |||
There was a problem hiding this comment.
Not sure if this breaks anything. Assuming our CI would run with the correct rust target by default, I think we're fine. This change allows all the rustdocs to be unified and have links to each crate on the left navigation.
There was a problem hiding this comment.
Not sure if this breaks anything. Assuming our CI would run with the correct rust target by default, I think we're fine. This change allows all the rustdocs to be unified and have links to each crate on the left navigation.
it shouldn't, no. our ci doesn't use the right target (musl) but for docs I suspect it doesnt matter...
dmah42
approved these changes
Jan 14, 2024
|
the unused import should be unrelated (and I'm not sure how it snuck in). let me see if I can clean that up first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below pages were 404s on the website.
This PR removes the unused
/macrosand/implementorsroutes and unifies the rustdocs to fix the documentation. Includes some drive-by typo fixes.