Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of installer default #20

Closed
wants to merge 1 commit into from
Closed

Get rid of installer default #20

wants to merge 1 commit into from

Conversation

harikt
Copy link
Member

@harikt harikt commented Jan 17, 2016

I noticed a message in cakephp irc channel,

I'm trying to install cake on ubuntu using composer and I get this runtime error. any ideas? Plugin aura/installer-default is missing a require statement for a version of the composer-plugin-api package.
the command I'm using for the install is composer create-project --prefer-dist cakephp/app [app_name]
waspinator, could you open an issue at https://github.com/auraphp/Aura.Intl/ ?
sure
waspinator, also you could do a -vvv to tell composer to display more errors

May be we need v2 or I am also ok with the change for 1.x framework is no longer maintained .

Also when I testing the same command, I have not experienced the issue.

@dereuromark
Copy link

👍
This currently seems to effect every CakePHP user who tries to begin a fresh app.
https://github.com/cakephp/app#installation

So I think this is rather urgent.

//cc @pmjones

@bravo-kernel
Copy link

A fix for this would be more than welcome since it has broken Cakebox application provisioning. 👍

@dereuromark
Copy link

Just do NOT use composer selfupdate and use an older version of composer for the time being.
That will circumvent the issue for now.

@bravo-kernel
Copy link

Or temporarily roll back to your working composer version by running:

composer self-update --rollback 

@pmjones
Copy link
Member

pmjones commented Jan 17, 2016

How do we feel about an essentially-unchanged 2.x version that removes the aura-installer dependency?

@dereuromark
Copy link

@pmjones Sounds good

PS: This will most likely have introduced the issue: composer/composer@21f5933

@pmjones
Copy link
Member

pmjones commented Jan 17, 2016

@harikt: would you care to begin a 2.x branch and remove the aura-installer requirement? We can make other very minor administrative changes as needed, while leaving the API and behavior intact.

@dereuromark
Copy link

@pmjones Is this project still maintained? Looks like nothing happened for almost a year.
As CakePHP uses it as a direct (hard) dependency, it is vital for us that this package is bugfixed and working.
If you need any help here, please feel free to reach out. There is the option for maintenance help for the library if desired.

@pmjones
Copy link
Member

pmjones commented Jan 17, 2016

@dereuromark I'll take any help you can give. If you want to nominate a maintainer from Cake-land I can set permissions as needed. @harikt is the obvious first choice here given his long and distinguished history with the project, but if he declines, we can pick someone else.

@bravo-kernel
Copy link

👏

josegonzalez added a commit to josegonzalez/composer that referenced this pull request Jan 17, 2016
…i even during installation"

This reverts commit 21f5933.

Commit 21f5933 breaks fresh installations of cakephp applications, or
any project where a dependency uses a different composer plugin
installer than the upstream project.

Closes auraphp/Aura.Intl#20
@dereuromark
Copy link

The only problem I see is that all composer packages of CakePHP 3.0/3.1 contain a 1.1 requirement ( https://github.com/cakephp/cakephp/blob/master/composer.json#L26 ).
It will break all apps if we introduce a new major version here.
Thus the revert first: composer/composer#4784

And we have then time to develop a 2.x branch :)
This new 2.x branch could be the default for all CakePHP 3.2+ versions then.

@josegonzalez
Copy link

The actual bug is a composer bug, not aura, though we can still probably do this change if people think its a good idea...

@pmjones
Copy link
Member

pmjones commented Jan 17, 2016

I am happy to defer to your judgment as to whether a 2.x is needed. (My guess is that any 1.x releease that removes the dependency is technically a BC break any hypothetical Aura 1.x users, so 2.x is probably the way to go.)

@dereuromark
Copy link

I agree, we better start the 2.x branch for this to be on the safe side.

@josegonzalez
Copy link

Why don't we just add the dependency to aura.installer-default on the composer api package and release a 1.1.0 of that and then a point release of this? I don't know what in cakephp depends on this package, but we can presumably also bump that up?

@Seldaek
Copy link

Seldaek commented Jan 17, 2016

I merged @josegonzalez's revert, and will investigate that later when I find a second, please don't act rashly here as I'd like to make sure the issue is reproducible still. I'll report back.

@harikt
Copy link
Member Author

harikt commented Jan 18, 2016

Hi all,

Thanks for all your comments. There are 2 alternatives and a few things we need to address here.

1 ) Cake depends on "aura/intl": "1.1.*", ( https://github.com/cakephp/cakephp/blob/master/composer.json#L26 ) that means it can take only bug fix. So this needs a patch of form 1.1.2 .
2 ) So what @josegonzalez mentioned in comment seems the only fix. In that case some packages which are not really needed will still be installed.

The problem with a fix 1.1.2 removing the dependency on aura-installer-default is if someone do an update on the v1 framework, it will effect them.

So only way is a 2.x package as mentioned by @pmjones . We could bring a 2.x branch without much api changes. Or if you guys need any improvements we can make that also happen in that version.

I hope I will be here to help with what I can. If there is anyone interested to be part of maintaining is also welcome to be part of the project .

We can do what you need.

Thank you

@harikt
Copy link
Member Author

harikt commented Jan 18, 2016

Hi all,
I have started a 2.x branch .

There is a failure in 7.x and hhvm . Both seems similar https://travis-ci.org/auraphp/Aura.Intl/jobs/103042075 , https://travis-ci.org/auraphp/Aura.Intl/jobs/103042074 . If anyone is interested to send a fix happy for it, else will look when I get some time.

If there is any changes needed without breaking the API ( we are pushing this for cakephp and not to break their api ) , we can also discuss the same.

2.x branch will fix #17, #18, #19, #20 .

Thank you.

@Seldaek
Copy link

Seldaek commented Jan 18, 2016

So just FYI I looked at the problem of yesterday and it was just me being silly.. I forgot that the composer-plugin-api check should on apply to packages of type composer-plugin. composer-installer typed packages are fine as is. So the code is back but fixed and hopefully y'all can keep doing whatever you were doing before here :)

@harikt
Copy link
Member Author

harikt commented Jan 18, 2016

Thank you @Seldaek . That will actually fix the cake installation issue.

I am closing this PR and issues for it will no longer will apply.

And in 2.x I probably added a fix so api is compatible with 5.x and 7.x version ( #22 ) .

I don't know if that is needed or the plans for future .

If anyone is interested please give some feedback .

Thank you

@harikt harikt closed this Jan 18, 2016
@harikt harikt added the 1.x label Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants