Skip to content

Commit

Permalink
fix(typescript): fix few typing conflicts by moving e2e files
Browse files Browse the repository at this point in the history
The default cypress folder (out of test folder) can fix weird typing conflicts.
  • Loading branch information
3cp committed May 3, 2020
1 parent 87c2023 commit 156fb6e
Show file tree
Hide file tree
Showing 21 changed files with 23 additions and 48 deletions.
12 changes: 1 addition & 11 deletions skeleton/common/tsconfig.json__if_typescript
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,6 @@

// @if feat.webpack
"module": "esnext",
"skipLibCheck": true,
// @endif

// @if feat.cypress && feat.karma
"types": ["jasmine"],
// @endif

// @if feat.cypress && feat.jest && feat['cli-bundler']
"types": ["node", "jest"],
// @endif

// @if feat.protractor && feat.jest
Expand Down Expand Up @@ -56,8 +47,7 @@
// @if feat.plugin
"dev-app",
// @endif
"test",
"types"
"test"
],
"atom": {
"rewriteTsconfig": false
Expand Down
8 changes: 1 addition & 7 deletions skeleton/cypress/cypress.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ const HOST = CLIOptions.getFlagValue('host') || aureliaConfig.platform.host;

module.exports = {
config: {
baseUrl: `http://${HOST}:${PORT}`,
fixturesFolder: 'test/e2e/fixtures',
integrationFolder: 'test/e2e/integration',
pluginsFile: 'test/e2e/plugins/index.js',
screenshotsFolder: 'test/e2e/screenshots',
supportFile: 'test/e2e/support/index.js',
videosFolder: 'test/e2e/videos'
baseUrl: `http://${HOST}:${PORT}`
}
};
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"strict": true,
"baseUrl": "../../node_modules",
"baseUrl": "../node_modules",
"target": "es5",
"types": [
"cypress"
Expand Down
15 changes: 15 additions & 0 deletions skeleton/protractor/e2e/tsconfig.json__if_typescript
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"strict": true,
"baseUrl": "../node_modules",
"target": "es5",
"types": [
"node",
"jasmine"
]
},
"include": [
"**/*.ts"
]
}
4 changes: 2 additions & 2 deletions skeleton/protractor/protractor.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ const config = {

specs: [
// @if feat.babel
'**/*.e2e.js'
'e2e/**/*.e2e.js'
// @endif
// @if feat.typescript
'**/*.e2e.ts'
'e2e/**/*.e2e.ts'
// @endif
],

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {PageObjectWelcome} from './welcome.po';
import {PageObjectSkeleton} from './skeleton.po';
import {config} from '../../protractor.conf';
import {config} from '../protractor.conf';
// @if feat.typescript
import {browser, element, by, By, $, $$, ExpectedConditions} from 'aurelia-protractor-plugin/protractor';
// @endif
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {PageObjectWelcome} from './welcome.po';
import {PageObjectSkeleton} from './skeleton.po';
import {config} from '../../protractor.conf';
import {config} from '../protractor.conf';
// @if feat.typescript
import {browser, element, by, By, $, $$, ExpectedConditions} from 'aurelia-protractor-plugin/protractor';
// @endif
Expand Down
3 changes: 0 additions & 3 deletions skeleton/webpack/types__if_typescript/fetch.d.ts

This file was deleted.

17 changes: 0 additions & 17 deletions skeleton/webpack/types__if_typescript/system.d.ts

This file was deleted.

0 comments on commit 156fb6e

Please sign in to comment.