fix(cli-bundler): browser ignore field should return empty object ins…

…tead of undefined
aurelia · Sep 8, 2020 · 58d8355 · 58d8355
1 parent 99cd678
commit 58d8355
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/build/stub-module.js b/lib/build/stub-module.js
@@ -27,7 +27,7 @@ const UNAVAIABLE_CORE_MODULES = [
   'tls'
 ];
 
-const EMPTY_MODULE = 'define(function(){});';
+const EMPTY_MODULE = 'define(function(){return {};});';
 
 function resolvePath(packageName, root) {
   return path.relative(root, Utils.resolvePackagePath(packageName)).replace(/\\/g, '/');

diff --git a/spec/lib/build/stub-module.spec.js b/spec/lib/build/stub-module.spec.js
@@ -48,10 +48,10 @@ describe('StubCoreNodejsModule', () => {
   });
 
   it('stubs empty module for some core module', () => {
-    expect(stubModule('dns', 'src')).toBe('define(function(){});');
+    expect(stubModule('dns', 'src')).toBe('define(function(){return {};});');
   });
 
   it('stubs empty module for __ignore__', () => {
-    expect(stubModule('__ignore__', 'src')).toBe('define(function(){});');
+    expect(stubModule('__ignore__', 'src')).toBe('define(function(){return {};});');
   });
 });