Skip to content

Commit

Permalink
feat: switch from libsass to dart-sass
Browse files Browse the repository at this point in the history
Because dart-sass is now the reference implementation of sass.
  • Loading branch information
3cp committed Apr 6, 2020
1 parent 962c539 commit 5da5355
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions lib/dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"gulp-postcss": "^8.0.0",
"gulp-protractor": "^4.1.1",
"gulp-rename": "^2.0.0",
"gulp-sass": "^4.0.2",
"gulp-dart-sass": "^1.0.0",
"gulp-sourcemaps": "^2.6.5",
"gulp-stylus": "^2.7.0",
"gulp-tslint": "^8.1.4",
Expand Down Expand Up @@ -80,13 +80,13 @@
"less": "^3.11.1",
"less-loader": "^5.0.0",
"minimatch": "^3.0.4",
"node-sass": "^4.13.1",
"postcss-loader": "^3.0.0",
"postcss-url": "^8.0.0",
"promise-polyfill": "^8.1.3",
"protractor": "^5.4.3",
"regenerator-runtime": "^0.13.3",
"requirejs": "^2.3.6",
"sass": "^1.26.3",
"sass-loader": "^8.0.2",
"style-loader": "^1.1.3",
"stylus": "^0.54.7",
Expand Down
8 changes: 4 additions & 4 deletions skeleton/cli-bundler/aurelia_project/tasks/process-css.ext
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import notify from 'gulp-notify';
import less from 'gulp-less';
// @endif
// @if feat.sass
import sass from 'gulp-sass';
import sass from 'gulp-dart-sass';
// @endif
// @if feat.stylus
import stylus from 'gulp-stylus';
Expand All @@ -35,7 +35,7 @@ import * as notify from 'gulp-notify';
import * as less from 'gulp-less';
// @endif
// @if feat.sass
import * as sass from 'gulp-sass';
import * as sass from 'gulp-dart-sass';
// @endif
// @if feat.stylus
import * as stylus from 'gulp-stylus';
Expand All @@ -59,7 +59,7 @@ export default function processCSS() {
.pipe(less())
// @endif
// @if feat.sass
.pipe(sass().on('error', sass.logError))
.pipe(sass.sync().on('error', sass.logError))
// @endif
// @if feat.stylus
.pipe(stylus())
Expand Down Expand Up @@ -90,7 +90,7 @@ export function pluginCSS(dest) {
.pipe(less())
// @endif
// @if feat.sass
.pipe(sass().on('error', sass.logError))
.pipe(sass.sync().on('error', sass.logError))
// @endif
// @if feat.stylus
.pipe(stylus())
Expand Down
2 changes: 1 addition & 1 deletion skeleton/cli-bundler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
// @endif

// @if feat.sass
"gulp-sass": "",
"gulp-dart-sass": "",
// @endif

// @if feat.stylus
Expand Down
2 changes: 1 addition & 1 deletion skeleton/webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

// @if feat.sass
"sass-loader": "",
"node-sass": "",
"sass": "",
// @endif

// @if feat.stylus
Expand Down

0 comments on commit 5da5355

Please sign in to comment.