Skip to content

Commit

Permalink
fix(skeleton): fix Promise polyfill on IE
Browse files Browse the repository at this point in the history
Load promise-polyfill before loading aurelia-bootstrapper. The polyfill can be removed if user don't need to support IE.

closes #1079
  • Loading branch information
3cp committed Apr 2, 2019
1 parent f572f42 commit bc377dc
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
"opn": "^5.4.0",
"postcss-loader": "^3.0.0",
"postcss-url": "^8.0.0",
"promise-polyfill": "^8.1.0",
"protractor": "^5.4.2",
"regenerator-runtime": "0.13.2",
"requirejs": "^2.3.6",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions skeleton/cli-bundler/aurelia_project/aurelia.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@
{
"name": "vendor-bundle.js",
"prepend": [
"node_modules/promise-polyfill/dist/polyfill.min.js",
// @if feat.requirejs
"node_modules/requirejs/require.js"
// @endif
Expand Down
1 change: 1 addition & 0 deletions skeleton/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"minimatch": "",
"through2": "",
"vinyl-fs": "",
"promise-polyfill": "",

// @if feat.babel
"regenerator-runtime": "",
Expand Down
1 change: 1 addition & 0 deletions skeleton/webpack/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ module.exports = ({ production, server, extractCss, coverage, analyze, karma } =
$: 'jquery',
jQuery: 'jquery',
// @endif
'Promise': ['promise-polyfill', 'default']
}),
new ModuleDependenciesPlugin({
'aurelia-testing': ['./compile-spy', './view-spy']
Expand Down

0 comments on commit bc377dc

Please sign in to comment.