chore(skeleton): remove core-js as the import is too late for IE11

Because src/main is executed after aurelia-bootstrapper. Promise has to be polyfilled before aurelia-bootstrapper.
aurelia · Apr 1, 2019 · f572f42 · f572f42
1 parent 24e2d88
commit f572f42
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/lib/dependencies.json b/lib/dependencies.json
@@ -29,7 +29,6 @@
   "clean-webpack-plugin": "^1.0.1",
   "connect-history-api-fallback": "^1.6.0",
   "copy-webpack-plugin": "^5.0.0",
-  "core-js": "^3.0.0",
   "cross-env": "^5.2.0",
   "cssnano": "^4.1.10",
   "css-loader": "^1.0.0",

diff --git a/skeleton/common/package.json b/skeleton/common/package.json
@@ -21,7 +21,6 @@
     "aurelia-cli": "",
     "aurelia-testing": "",
     "aurelia-tools": "",
-    "core-js": "",
     "gulp": "",
     "minimatch": "",
     "through2": "",

diff --git a/skeleton/plugin/dev-app/main.ext b/skeleton/plugin/dev-app/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 // @if feat.typescript

diff --git a/skeleton/scaffold-minimum/src/main.ext b/skeleton/scaffold-minimum/src/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 // @if feat.typescript

diff --git a/skeleton/scaffold-navigation/src/main.ext b/skeleton/scaffold-navigation/src/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 import 'bootstrap';