-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failure to handle the "browser" field in dependencies' package.json #581
Comments
About 10% of the dependencies in a typical setup, and aurelia-cli 0.27.0 fails to handle the "browser" section and, considering the above, this post is more like a bug report than an enhancement request. |
Thanks for opening these issues, all of them should be supported by the CLI. Just because they are flagged as enhancements, does not necessarily mean that they do not take priority over issues flagged as bugs. In fact, improving the bundler is a priority of mine, and the issues you've opened will help a lot, so thanks! |
Example package: https://github.com/mzabriskie/axios |
Adding another example package in case multiple instances were useful. https://www.npmjs.com/package/uuid |
I'm submitting a bug report
0.27.0
Please tell us about your environment:
Operating System:
Windows 8.1
Node Version:
6.10.0
NPM Version:
3.10.10
Current behavior:
Several libs show a "browser" field in their package.json, which can be of several forms :
aurelia-cli ignores this information, thus requiring the same dependencies as the node version... which inevitably fails.
As a result, users have to edit aurelia.json to add a "main" section, or worse edit the library to hard-code any arguments that change its behaviour for the browser.
Expected/desired behavior:
The "browser" section of package.json should be taken into account when loading and tracing a dependency module.
Make the inclusion of certain libraries (e.g. pouchdb-adapter-memory) seamless, save the developers' time, and more importantly bring peace and happiness among all nations and people.
The text was updated successfully, but these errors were encountered: