feat(update): Add update command #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to update official aurelia dependencies in one command
|
@joelcoxokc @zewa666 @ahmedshuhel The only issue remaining that I see is jspm clean is run too early once the first promise is resolved. Gladly accept any ideas for fixing that otherwise we can open an issue to add that as an enhancement to spawn-promise which should resolve that issue. |
| @@ -0,0 +1,14 @@ | |||
| import * as logger from '../lib/logger'; | |||
There was a problem hiding this comment.
So according to our last discussion should we do this one via require?
|
@PWKad Would you like me to convert this PR to our new API? |
ryan-smith-virteom
added a commit
to ryan-smith-virteom/cli
that referenced
this pull request
Mar 6, 2018
…ride function aurelia/testing ComponentTester wasn't working. Bootstrapper failed to return with an error that there was no loader defined. Tracked the error down to a dependency reassigning window.require because define.amd was undefined. aurelia/testing issue aurelia#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to update official aurelia dependencies in one command