feat: upgrade to babel-preset-env #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cp
changed the title
3cp
changed the title
3cp
commented
Jul 30, 2018
| @@ -1,6 +1,5 @@ | |||
| import environment from './environment'; | |||
| import {PLATFORM} from 'aurelia-pal'; | |||
| import 'babel-polyfill'; | |||
There was a problem hiding this comment.
aurelia-bootstrapper does load aurelia-polyfills. This line is unnecessary.
3cp
commented
Jul 30, 2018
| }, | ||
| "loose": true, | ||
| "modules": process.env.BABEL_TARGET === 'node' ? 'commonjs' : false, | ||
| "useBuiltIns": true |
3cp
commented
Jul 30, 2018
| } | ||
| ] | ||
| ], | ||
| "stage-1" |
There was a problem hiding this comment.
For webpack, use "stage-1" to replace handpicked "transform-class-properties".
Added "syntax-flow" for webpack setup too.
3cp
changed the title
3cp
commented
Jul 30, 2018
| "last 2 versions", | ||
| "not ie <= 11" | ||
| ], | ||
| "uglify": process.env.NODE_ENV === 'production', |
There was a problem hiding this comment.
As we are using terser now, we don't need to ask preset-env to generate compatible code for uglify-js v3.
3cp
commented
Jul 30, 2018
| ], | ||
| "presets": [ | ||
| [ | ||
| "env", { | ||
| "targets": process.env.BABEL_TARGET === 'node' ? { | ||
| "node": process.env.IN_PROTRACTOR ? '6' : 'current' | ||
| } : { | ||
| "browsers": [ | ||
| "last 2 versions", | ||
| "not ie <= 11" |
There was a problem hiding this comment.
Aurelia claimed supporting IE10.
JeroenVinke
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify babelrc for webpack and cli bundler.
Cleaned up webpack babelrc to use same plugins as other setup.
Add IE10/11 support back to webpack setup as that is what Aurelia claimed to support.
closes #754, #909