feat: backport resolve #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove unnecessary deps, tweak build scripts chore: prepare linting scripts chore: revert unwanted changes to package json chore: fix rollup build scripts fix: tweak doc scripts chore: fix rollup config fix: doc script fix: tweak doc script fix: doc build config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the request at #227, a backport of resolve is provided in this PR.
This should help applications prepare for v2 migration, or if they like, stay with v1 without having to worry about Typescript.
container.get()typings so that.get(NewInstance.of())/Lazy/Factoryetc... will give correct type inference.@lazy/@newInstaceas the existing typings are incorrect, the type of the keys are used to validate the target class of the decoratorThanks @m-gallesio for requesting this.
Closes #227
cc @thomas-darling for your awareness since you are with one of the big v1 applications that I'm aware of.