Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: property accessor ignore instrumenter #578

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fix: property accessor ignore instrumenter #578

merged 2 commits into from
Feb 2, 2023

Conversation

Sayan751
Copy link
Member

This supports instrumentation code from @jsdevtools/coverage-istanbul-loader.

Fixes #571

This supports instrumentation code from @jsdevtools/coverage-istanbul-loader.

Fixes #571
@Sayan751
Copy link
Member Author

Sayan751 commented Feb 2, 2023

@bigopon Can you please take a look at this?

Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good to me.

@bigopon bigopon merged commit b9ee21c into aurelia:master Feb 2, 2023
@Sayan751 Sayan751 deleted the topic/refactor-property-accessor-for-istanbul branch February 3, 2023 06:06
@Sayan751
Copy link
Member Author

Sayan751 commented Feb 3, 2023

Thanks @bigopon! Would be great, if you can release the patch.

@bigopon
Copy link
Member

bigopon commented Feb 7, 2023

@Sayan751 it's been released in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumented code for code coverage is not getting parsed correclty
2 participants