Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the opener tab ID to browser.tabs.create #70

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

jtotht
Copy link
Contributor

@jtotht jtotht commented Mar 17, 2022

This means that:

  • the RSS preview tab opens in the same container in which the opener tab was open (without need for extra permissions);
  • the RSS preview tab appears right next to the tab from which it was opened, not at the end of the tab bar; and
  • if the user closes the tab without switching tabs between opening and closing the tab, Firefox activates the previous tab (i.e. from which the RSS preview was opened), not the next one.

This means that:
- the RSS preview tab opens in the same container in which the opener
  tab was open (without need for extra permissions);
- the RSS preview tab appears right next to the tab from which it was
  opened, not at the end of the tab bar; and
- if the user closes the tab without switching tabs between opening and
  closing the tab, Firefox activates the previous tab (i.e. from which
  the RSS preview was opened), not the next one.
@aureliendavid aureliendavid merged commit 4c68719 into aureliendavid:master Mar 18, 2022
@aureliendavid
Copy link
Owner

that's great, thank for the contribution!

I've added it to release v3.17, pushed on github and amo

thanks again

@jtotht
Copy link
Contributor Author

jtotht commented Mar 18, 2022

Thanks, that was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants