Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up and made code conform to PEP-8 #3

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

danidee10
Copy link
Contributor

This PR cleans up the code (Removed unused variables and an old pattern) for this seed project.
It also formats the code and makes it conform to PEP-8

@Annyv2
Copy link
Contributor

Annyv2 commented Dec 22, 2016

Hi @danidee10! Thanks again for your contribution, I will review this PR either later today or tomorrow.

@Annyv2 Annyv2 self-requested a review December 22, 2016 15:27
@Annyv2
Copy link
Contributor

Annyv2 commented Dec 22, 2016

@danidee10 We will update the docs accordingly once we approve this PR. Thanks again!

@danidee10
Copy link
Contributor Author

@Annyv2 i also noticed that the JWT's Auth0 generates are an hour ahead of my servers and PyJWT has a library specific check it does to verify that the date and time the token was issued (iat claim) is less than the server's time.

Because of this check i can't validate the JWT in production (Everything work's fine in the Test environment) and it keeps on throwing an error.

InvalidIssuedAtError('Issued At claim (iat) cannot be in the future.')

There are two workarounds for this:

  1. Disable the check by passing options={'verify_iat': False} to jwt.decode
  2. Bump up the server's time (Not very elegant as other services/apps might malfunction).

So is this something that can be included in the docs for users to watch out for?
Or Maybe i need to configure something else in Auth0?

More context on this issue can be found here jpadilla/pyjwt#190

Thanks for all the great responses so far!

@chenkie chenkie merged commit 9954f2e into auth0-samples:master Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants