Add support for Social Native Token Exchange endpoint #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Jan 31, 2020
auth0/src/main/java/com/auth0/android/authentication/AuthenticationAPIClient.java
Show resolved
Hide resolved
lbalmaceda
commented
Jan 31, 2020
auth0/src/main/java/com/auth0/android/authentication/AuthenticationAPIClient.java
Show resolved
Hide resolved
stevehobbsdev
requested changes
Feb 5, 2020
auth0/src/test/java/com/auth0/android/authentication/AuthenticationAPIClientTest.java
Outdated
Show resolved
Hide resolved
stevehobbsdev
approved these changes
Feb 6, 2020
SebRenon
reviewed
Mar 5, 2020
| * @return a request to configure and start that will yield {@link Credentials} | ||
| */ | ||
| @SuppressWarnings("WeakerAccess") | ||
| public AuthenticationRequest loginWithNativeSocialToken(@NonNull String token, @NonNull String tokenType) { |
There was a problem hiding this comment.
@lbalmaceda Where can I find the list of the supported tokenTypes. Is there one for Google SignIn?
From the doc (https://auth0.com/docs/api/authentication#token-exchange-for-native-social) it looks like only apple-authz-code is supported:
Identifier that indicates the type of subject_token.
Currently supported native social values are:
http://auth0.com/oauth/token-type/apple-authz-code.
There was a problem hiding this comment.
Google Sign-In is not supported yet, unfortunately. There's an ongoing effort to add Facebook Sign-In. The server-side team is working on this case by case per request from our customers.
That link you posted will be updated when support for another provider is added. And of course, once it's available, we will update the SDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a small addition to the pool of supported endpoints. It's meant to exchange an external provider's token for auth0 tokens. AKA sign in into Auth0 with an external native provider.
References
See https://auth0.com/docs/api/authentication#token-exchange-for-native-social
Testing
I did not test this manually. Will be doing so soon.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors