Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and save State and Nonce variables for WebAuthProvider #50

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Dec 2, 2016

If any of the two parameters wasn't set by the user explicitly, the generator function would be called more than once per session, leading to an invalid state/nonce check.

@lbalmaceda lbalmaceda force-pushed the fix-statefull-check branch 2 times, most recently from 1f77a22 to 63d3322 Compare December 2, 2016 19:38
@hzalaz hzalaz added this to the 1.3.0 milestone Dec 12, 2016
@hzalaz hzalaz force-pushed the fix-statefull-check branch from 63d3322 to a594845 Compare December 12, 2016 21:29
@hzalaz hzalaz merged commit 8c9cf7f into master Dec 12, 2016
@hzalaz hzalaz deleted the fix-statefull-check branch December 12, 2016 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants