Add flag to authenticate with OIDC mode #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
new-pipeline-on-legacy-methods
branch
from
3168830 to
963c579
Compare
hzalaz
suggested changes
Dec 21, 2016
| @@ -421,6 +450,10 @@ public AuthenticationRequest loginWithEmail(@NonNull String email, @NonNull Stri | |||
| @SuppressWarnings("WeakerAccess") | |||
| @Deprecated | |||
| public Request<UserProfile, AuthenticationException> tokenInfo(@NonNull String idToken) { | |||
There was a problem hiding this comment.
This is wrong, userInfo is meant for access_token
| @@ -191,6 +212,12 @@ public void setUserAgent(String userAgent) { | |||
| */ | |||
| @SuppressWarnings("WeakerAccess") | |||
| public AuthenticationRequest login(@NonNull String usernameOrEmail, @NonNull String password, @NonNull String connection) { | |||
There was a problem hiding this comment.
What I'd do is to chose the grant type and legacy endpoint based on the pipeline flag. If it's off, ro and connection is used otherwise token and realm
| @@ -223,7 +250,7 @@ public AuthenticationRequest login(@NonNull String usernameOrEmail, @NonNull Str | |||
| Map<String, Object> requestParameters = ParameterBuilder.newBuilder() | |||
There was a problem hiding this comment.
I'd keep this as it was, using password grant, since realm grant without a realm is pretty useless. We can recommend using the other method and even deprecating this or explaining the default directory restriction of password grant
lbalmaceda
force-pushed
the
new-pipeline-on-legacy-methods
branch
3 times, most recently
from
f8e2c16 to
f281ef4
Compare
hzalaz
force-pushed
the
new-pipeline-on-legacy-methods
branch
from
f281ef4 to
792be5d
Compare
hzalaz
force-pushed
the
new-pipeline-on-legacy-methods
branch
from
792be5d to
b768025
Compare
hzalaz
changed the title
hzalaz
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make legacy authentication methods use
/oauth/tokenendpoint ifclient.setOAuth2Preferred(true)is called. The methods that change it's behavior with the flag are:login(String, String, String)--> callslogin(String, String)and sets the connection as realm.tokenInfo(String)--> callsuserInfo(String)signUp(String, String, String)--> replaces the login call withlogin(String, String)and sets the connection as realm.signUp(String, String, String, String)--> replaces the login call withlogin(String, String)and sets the connection as realm.This PR depends on #56 as there was no way to set a
realmvalue before that.