Use ThreadPool to launch browser for authentication #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
reviewed
Sep 22, 2023
auth0/src/main/java/com/auth0/android/provider/CustomTabsController.java
Show resolved
Hide resolved
jimmyjames
approved these changes
Sep 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously we created a new instance of
Threadto launch the browser for authentication. This caused flakiness on the CI as we had to rely on the execution order of the VM. We have used our own Thread pool now. This optimizes the resources used and also helps us avoid the flakiness in the CI.References
Failure of CI here and such in the past - #688
Testing
We have added more verification now to ensure background switch is made