-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Passkey authentication support #764
Conversation
@@ -34,11 +34,11 @@ version = getVersionFromFile() | |||
logger.lifecycle("Using version ${version} for ${name}") | |||
|
|||
android { | |||
compileSdkVersion 31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, changing these versions we have to ensure any of our existing behaviour isn't breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poovamraj Any particular feature you see which need to be checked ? I did a high level testing and didn't see any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Added support to signup and signin using Passkey. This change introduces a new public class called
PasskeyAuthProvider
. It exposes two apis for the client to initiate the signup and signin flowPasskeyAuthProvider.signUp(auth0:Auth0)
PasskeyAuthProvider.signIn(auth0:Auth0)
#References
Webauthn
Passkeys
Google Credential Manager
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors