Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Passkey authentication support #764

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Added Passkey authentication support #764

merged 4 commits into from
Oct 28, 2024

Conversation

pmathew92
Copy link
Contributor

@pmathew92 pmathew92 commented Oct 22, 2024

Changes

Added support to signup and signin using Passkey. This change introduces a new public class called PasskeyAuthProvider . It exposes two apis for the client to initiate the signup and signin flow

  1. PasskeyAuthProvider.signUp(auth0:Auth0)
  2. PasskeyAuthProvider.signIn(auth0:Auth0)

#References
Webauthn
Passkeys
Google Credential Manager

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@pmathew92 pmathew92 requested a review from a team as a code owner October 22, 2024 10:57
@@ -34,11 +34,11 @@ version = getVersionFromFile()
logger.lifecycle("Using version ${version} for ${name}")

android {
compileSdkVersion 31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, changing these versions we have to ensure any of our existing behaviour isn't breaking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poovamraj Any particular feature you see which need to be checked ? I did a high level testing and didn't see any issues

arpit-jn
arpit-jn previously approved these changes Oct 25, 2024
Copy link

@arpit-jn arpit-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmathew92 pmathew92 merged commit b4dbd62 into main Oct 28, 2024
10 checks passed
@pmathew92 pmathew92 deleted the feature/SDK-5009 branch October 28, 2024 06:28
@pmathew92 pmathew92 restored the feature/SDK-5009 branch October 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants