Ensure closing the response body after it was parsed #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzalaz
suggested changes
Feb 20, 2017
| @@ -136,6 +138,11 @@ protected U parseUnsuccessfulResponse(Response response) { | |||
| } catch (IOException e) { | |||
| final Auth0Exception auth0Exception = new Auth0Exception("Error parsing the server response", e); | |||
| return errorBuilder.from("Request to " + url.toString() + " failed", auth0Exception); | |||
| } finally { | |||
| try { | |||
| body.close(); | |||
| } finally { | ||
| try { | ||
| body.close(); | ||
| } catch (Exception ignored) { |
There was a problem hiding this comment.
Should we only catch IOException instead all of them so we know when we fail to proper manage the errors?
lbalmaceda
force-pushed
the
fixed-close-response-body
branch
from
61c8b90 to
d6eaf7e
Compare
lbalmaceda
force-pushed
the
fixed-close-response-body
branch
from
d6eaf7e to
57fd185
Compare
lbalmaceda
force-pushed
the
fixed-close-response-body
branch
from
760ea08 to
43fc54e
Compare
hzalaz
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Body should be closed after we finish parsing the response. There are some methods like
body.string()that close the body internally, but if the call throws an exception we would need to callbody.close()manually.Related: square/okhttp#2311