Update Swift 5 / Xcode 10.2 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Project to Swift 5 Update Xcode 10.2 Project Settings Update Gems Updated CI to Xcode 10.2 Update Minimum iOS Deployment to 9.0 / Cocoapods Dependency
cocojoe
commented
Apr 23, 2019
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
There was a problem hiding this comment.
Apple recommends to add this file
cocojoe
commented
Apr 23, 2019
| @@ -14,7 +14,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| var window: UIWindow? | |||
|
|
|||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool { | |||
| internal func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | |||
There was a problem hiding this comment.
Swift 5 upgrade recommendations from compiler
cocojoe
commented
Apr 23, 2019
| @@ -13,7 +13,7 @@ Pod::Spec.new do |s| | |||
| s.source = { :git => "https://github.com/auth0/SimpleKeychain.git", :tag => s.version.to_s } | |||
| s.social_media_url = 'https://twitter.com/auth0' | |||
|
|
|||
| s.ios.deployment_target = '7.0' | |||
| s.ios.deployment_target = '9.0' | |||
There was a problem hiding this comment.
Even 9 is old but inline with Auth0.swift
cocojoe
commented
Apr 23, 2019
| s.ios.deployment_target = '7.0' | ||
| s.osx.deployment_target = '10.10' | ||
| s.ios.deployment_target = '9.0' | ||
| s.osx.deployment_target = '10.11' |
There was a problem hiding this comment.
Inline with Auth0.swift update, again kind of old
cocojoe
commented
Apr 23, 2019
| @@ -42,13 +42,6 @@ github "auth0/SimpleKeychain" | |||
|
|
|||
| ## Before Getting Started | |||
|
|
|||
| ### Objective-C | |||
There was a problem hiding this comment.
ObjC will go away in next major, starting to phase out.
hzalaz
approved these changes
Apr 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Default Project to Swift 5
Update Xcode 10.2 Project Settings
Update Gems
Updated CI to Xcode 10.2
Update Minimum iOS Deployment to 9.0 / Cocoapods Dependency
Update Test Dependencies
References
N/A
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If helpful, please include manual testing steps as well.
[NA] This change adds unit test coverage (or why not)
[x] This change has been tested on the latest version of the platform/language or why not
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All existing and new tests complete without errors